Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing "vehicle_part.h" includes #3172

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Sep 18, 2023

Summary

SUMMARY: Bugfixes "Hotfix build failure do to missing vehicle_part.h inclusion"

Purpose of change

  1. refactor: extract to vehicle_part.h #3104 changed header inclusions, and fixed all header inclusions
  2. feat(port): move vehicles in elevator #3151 was made without header inclusion in refactor: extract to vehicle_part.h #3104 since it wasn't merged yet
  3. feat(port): move vehicles in elevator #3151 got merged first, with all tests passing
  4. refactor: extract to vehicle_part.h #3104 got merged later, with all tests passing, however it was a lie! the source code changed after merging feat(port): move vehicles in elevator #3151, but no additional tests were ran on refactor: extract to vehicle_part.h #3104

Describe the solution

include "vehicle_part.h" header to "iexamine_elevator.cpp"

Describe alternatives you've considered

screm

Testing

local build passed, should be merged ASAP, sorry

Additional context

we should really use merge queue
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue

@scarf005 scarf005 enabled auto-merge (squash) September 18, 2023 00:33
@scarf005 scarf005 merged commit 1c5dd85 into cataclysmbnteam:upload Sep 18, 2023
7 of 8 checks passed
@github-actions github-actions bot added the src changes related to source code. label Sep 18, 2023
@scarf005 scarf005 deleted the fix-forward-declaration branch September 18, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants